Skip to content

Use PyTorch's conventional inplace functions #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2024
Merged

Use PyTorch's conventional inplace functions #7332

merged 2 commits into from
Mar 18, 2024

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Mar 14, 2024 •
edited
Loading

This pull request updates the code to use PyTorch's conventional inplace functions for weight initialization, torch.nn.init.normal_(), instead of torch.nn.init.normal(); since diffusers follows PyTorch's design principles.
@sayakpaul

sayakpaul
sayakpaul approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with the changes. Thank you!

@sayakpaul sayakpaul requested a review from yiyixuxu March 15, 2024 03:40
@yiyixuxu yiyixuxu merged commit e6a8492 into huggingface:main Mar 18, 2024
@tolgacangoz
Copy link
Contributor Author

Thanks for merging!

@tolgacangoz tolgacangoz deleted the update-inplace-functions branch March 18, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiyixuxu yiyixuxu yiyixuxu approved these changes

@sayakpaul sayakpaul sayakpaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolgacangoz @yiyixuxu @sayakpaul